/// Make sure pm_runtime_* calls does not use unnecessary IS_ERR_VALUE /// // Keywords: pm_runtime // Confidence: Medium // Copyright (C) 2013 Texas Instruments Incorporated - GPLv2. // URL: http://coccinelle.lip6.fr/ // Options: --include-headers virtual patch virtual context virtual org virtual report //---------------------------------------------------------- // Detection //---------------------------------------------------------- @runtime_bad_err_handle exists@ expression ret; position p; @@ ( ret@p = \(pm_runtime_idle\| pm_runtime_suspend\| pm_runtime_autosuspend\| pm_runtime_resume\| pm_request_idle\| pm_request_resume\| pm_request_autosuspend\| pm_runtime_get\| pm_runtime_get_sync\| pm_runtime_put\| pm_runtime_put_autosuspend\| pm_runtime_put_sync\| pm_runtime_put_sync_suspend\| pm_runtime_put_sync_autosuspend\| pm_runtime_set_active\| pm_schedule_suspend\| pm_runtime_barrier\| pm_generic_runtime_suspend\| pm_generic_runtime_resume\)(...); ... IS_ERR_VALUE(ret) ... ) //---------------------------------------------------------- // For context mode //---------------------------------------------------------- @depends on context@ identifier pm_runtime_api; expression ret; position runtime_bad_err_handle.p; @@ ( ret@p = pm_runtime_api(...); ... * IS_ERR_VALUE(ret) ... ) //---------------------------------------------------------- // For patch mode //---------------------------------------------------------- @depends on patch@ identifier pm_runtime_api; expression ret; position runtime_bad_err_handle.p; @@ ( ret@p = pm_runtime_api(...); ... - IS_ERR_VALUE(ret) + ret < 0 ... ) //---------------------------------------------------------- // For org and report mode //---------------------------------------------------------- @r depends on (org || report) exists@ position p1, p2; identifier pm_runtime_api; expression ret; position runtime_bad_err_handle.p; @@ ( ret@p = pm_runtime_api@p1(...); ... IS_ERR_VALUE@p2(ret) ... ) @script:python depends on org@ p1 << r.p1; p2 << r.p2; pm_runtime_api << r.pm_runtime_api; @@ cocci.print_main(pm_runtime_api,p1) cocci.print_secs("IS_ERR_VALUE",p2) @script:python depends on report@ p1 << r.p1; p2 << r.p2; pm_runtime_api << r.pm_runtime_api; @@ msg = "%s returns < 0 as error. Unecessary IS_ERR_VALUE at line %s" % (pm_runtime_api, p2[0].line) coccilib.report.print_report(p1[0],msg)
Name | Type | Size | Permission | Actions |
---|---|---|---|---|
alloc | Folder | 0755 |
|
|
debugfs | Folder | 0755 |
|
|
check_bq27xxx_data.cocci | File | 3.42 KB | 0644 |
|
d_find_alias.cocci | File | 1.28 KB | 0644 |
|
drm-get-put.cocci | File | 1.93 KB | 0644 |
|
err_cast.cocci | File | 1.07 KB | 0644 |
|
kstrdup.cocci | File | 2.4 KB | 0644 |
|
memdup.cocci | File | 1.35 KB | 0644 |
|
memdup_user.cocci | File | 1.28 KB | 0644 |
|
platform_no_drv_owner.cocci | File | 3.78 KB | 0644 |
|
pm_runtime.cocci | File | 2.34 KB | 0644 |
|
ptr_ret.cocci | File | 1.77 KB | 0644 |
|
resource_size.cocci | File | 2.07 KB | 0644 |
|
simple_open.cocci | File | 1.21 KB | 0644 |
|
stream_open.cocci | File | 7.6 KB | 0644 |
|
vma_pages.cocci | File | 1.48 KB | 0644 |
|