/// Use WARN(1,...) rather than printk followed by WARN_ON(1) /// // Confidence: High // Copyright: (C) 2012 Julia Lawall, INRIA/LIP6. GPLv2. // Copyright: (C) 2012 Gilles Muller, INRIA/LiP6. GPLv2. // URL: http://coccinelle.lip6.fr/ // Comments: // Options: --no-includes --include-headers virtual patch virtual context virtual org virtual report @bad1@ position p; @@ printk(...); printk@p(...); WARN_ON(1); @r1 depends on context || report || org@ position p != bad1.p; @@ printk@p(...); *WARN_ON(1); @script:python depends on org@ p << r1.p; @@ cocci.print_main("printk + WARN_ON can be just WARN",p) @script:python depends on report@ p << r1.p; @@ msg = "SUGGESTION: printk + WARN_ON can be just WARN" coccilib.report.print_report(p[0],msg) @ok1 depends on patch@ expression list es; position p != bad1.p; @@ -printk@p( +WARN(1, es); -WARN_ON(1); @depends on patch@ expression list ok1.es; @@ if (...) - { WARN(1,es); - } // -------------------------------------------------------------------- @bad2@ position p; @@ printk(...); printk@p(...); WARN_ON_ONCE(1); @r2 depends on context || report || org@ position p != bad1.p; @@ printk@p(...); *WARN_ON_ONCE(1); @script:python depends on org@ p << r2.p; @@ cocci.print_main("printk + WARN_ON_ONCE can be just WARN_ONCE",p) @script:python depends on report@ p << r2.p; @@ msg = "SUGGESTION: printk + WARN_ON_ONCE can be just WARN_ONCE" coccilib.report.print_report(p[0],msg) @ok2 depends on patch@ expression list es; position p != bad2.p; @@ -printk@p( +WARN_ONCE(1, es); -WARN_ON_ONCE(1); @depends on patch@ expression list ok2.es; @@ if (...) - { WARN_ONCE(1,es); - }
Name | Type | Size | Permission | Actions |
---|---|---|---|---|
array_size.cocci | File | 1.66 KB | 0644 |
|
badty.cocci | File | 1.68 KB | 0644 |
|
boolconv.cocci | File | 1.44 KB | 0644 |
|
boolinit.cocci | File | 2.2 KB | 0644 |
|
boolreturn.cocci | File | 698 B | 0644 |
|
bugon.cocci | File | 1.45 KB | 0644 |
|
cond_no_effect.cocci | File | 2.04 KB | 0644 |
|
cstptr.cocci | File | 827 B | 0644 |
|
doubleinit.cocci | File | 1.36 KB | 0644 |
|
ifaddr.cocci | File | 659 B | 0644 |
|
ifcol.cocci | File | 1.21 KB | 0644 |
|
irqf_oneshot.cocci | File | 1.91 KB | 0644 |
|
noderef.cocci | File | 1.17 KB | 0644 |
|
of_table.cocci | File | 1.33 KB | 0644 |
|
orplus.cocci | File | 1 KB | 0644 |
|
returnvar.cocci | File | 1.22 KB | 0644 |
|
semicolon.cocci | File | 1.04 KB | 0644 |
|
warn.cocci | File | 1.62 KB | 0644 |
|