/// Use BUG_ON instead of a if condition followed by BUG. /// //# This makes an effort to find cases where BUG() follows an if //# condition on an expression and replaces the if condition and BUG() //# with a BUG_ON having the conditional expression of the if statement //# as argument. // // Confidence: High // Copyright: (C) 2014 Himangi Saraogi. GPLv2. // Comments: // Options: --no-includes --include-headers virtual patch virtual context virtual org virtual report //---------------------------------------------------------- // For context mode //---------------------------------------------------------- @depends on context@ expression e; @@ *if (e) BUG(); //---------------------------------------------------------- // For patch mode //---------------------------------------------------------- @depends on patch@ expression e; @@ -if (e) BUG(); +BUG_ON(e); //---------------------------------------------------------- // For org and report mode //---------------------------------------------------------- @r depends on (org || report)@ expression e; position p; @@ if (e) BUG@p (); @script:python depends on org@ p << r.p; @@ coccilib.org.print_todo(p[0], "WARNING use BUG_ON") @script:python depends on report@ p << r.p; @@ msg="WARNING: Use BUG_ON instead of if condition followed by BUG.\nPlease make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h)" coccilib.report.print_report(p[0], msg)
Name | Type | Size | Permission | Actions |
---|---|---|---|---|
array_size.cocci | File | 1.66 KB | 0644 |
|
badty.cocci | File | 1.68 KB | 0644 |
|
boolconv.cocci | File | 1.44 KB | 0644 |
|
boolinit.cocci | File | 2.2 KB | 0644 |
|
boolreturn.cocci | File | 698 B | 0644 |
|
bugon.cocci | File | 1.45 KB | 0644 |
|
cond_no_effect.cocci | File | 2.04 KB | 0644 |
|
cstptr.cocci | File | 827 B | 0644 |
|
doubleinit.cocci | File | 1.36 KB | 0644 |
|
ifaddr.cocci | File | 659 B | 0644 |
|
ifcol.cocci | File | 1.21 KB | 0644 |
|
irqf_oneshot.cocci | File | 1.91 KB | 0644 |
|
noderef.cocci | File | 1.17 KB | 0644 |
|
of_table.cocci | File | 1.33 KB | 0644 |
|
orplus.cocci | File | 1 KB | 0644 |
|
returnvar.cocci | File | 1.22 KB | 0644 |
|
semicolon.cocci | File | 1.04 KB | 0644 |
|
warn.cocci | File | 1.62 KB | 0644 |
|